Appends the saved objects documents count to the CoreUsageData service#124308
Conversation
…e as savedObjectsDocsCounts to distinguish it from the lucene docs count we already report
|
@elasticmachine merge upstream |
| _meta: { | ||
| description: | ||
| 'The number of documents in the index, including hidden nested documents.', | ||
| 'The number of lucene documents in the index, including hidden nested documents.', |
There was a problem hiding this comment.
Updates the description to make it clear what the number of documents is from.
TinaHeiligers
left a comment
There was a problem hiding this comment.
Self review
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
I agree with using a new field name, but I wonder if we have no use cases to use the lucene document/deleted count, isn't it better to stop sending it? Although it feels fairly cheap to send two more fields, everything adds up in the snapshot size and telemetry cluster and I can't imagine the lucene document count ever being useful. |
Agreed, however, I was also thinking about getting the so counts sooner rather than later, and removing fields means a reindex has to happen. Reindexing data has in my experience been a pain. |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
elastic#124308) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ad7c8de)
💔 Some backports could not be created
How to fixRe-run the backport manually: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
elastic#124308) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ad7c8de) # Conflicts: # docs/development/core/server/kibana-plugin-core-server.md # docs/development/core/server/kibana-plugin-core-server.mergesavedobjectmigrationmaps.md
elastic#124308) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ad7c8de) # Conflicts: # docs/development/core/server/kibana-plugin-core-server.md # docs/development/core/server/kibana-plugin-core-server.mergesavedobjectmigrationmaps.md
#124308) (#124562) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ad7c8de) # Conflicts: # docs/development/core/server/kibana-plugin-core-server.md # docs/development/core/server/kibana-plugin-core-server.mergesavedobjectmigrationmaps.md
#124308) (#124563) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ad7c8de) # Conflicts: # docs/development/core/server/kibana-plugin-core-server.md # docs/development/core/server/kibana-plugin-core-server.mergesavedobjectmigrationmaps.md
Resolves #120485
This PR adds the actually saved objects document count to the
CoreUsageDataServicepayload, retaining the original Lucene document count and other information about the store size from theGET _cat/indices/.kibanaAPI.In addition, this PR adds debug level logs for the Lucene document count and the saved objects documents count to make debugging easier.
Why not just change what we report?
I decided to keep the original payload and add the additional information rather than replace the docs count for 2 reasons:
_cat/indices/.kibana API. It would be confusing to simply replace the lucene docs count with that of the saved objects docs count because that's not what the_cat/indices/.kibana APIAPI returns.Changes:
In the example data payload (Advanced settings -> Usage Data -> cluster data:
In the logs
Logging configuration
Logs
How to test this:
core-usage-stats-serviceinkibana.ymlas described abovecluster statsto see an example of the data Kibana collectssavedObjectsunderservicesin the flyout and observe that we report thesavedObjectsDocsCountas another entry per index.core-usage-stats-servicelogs and observe we have two entries for docs counts: one for the Lucene document count and one for the saved objects document counts.Checklist
Risk Matrix
For maintainers